Ramsay Jones
2014-10-23 22:58:21 UTC
Commit 8796e182 ("receive-pack.c: use a single transaction when
atomic-push is negotiated", 21-10-2014) added the 'transaction'
and 'err' variables as external symbols.
Noticed by sparse. ("'err' was not declared. Should it be static?")
Signed-off-by: Ramsay Jones <***@ramsay1.demon.co.uk>
---
Hi Ronnie,
If you need to re-roll your 'rs/ref-transaction-send-pack' branch, could
you please squash this into the re-rolled version of commit 8796e182.
Thanks!
ATB,
Ramsay Jones
builtin/receive-pack.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/builtin/receive-pack.c b/builtin/receive-pack.c
index 030698c..7f6d814 100644
--- a/builtin/receive-pack.c
+++ b/builtin/receive-pack.c
@@ -68,8 +68,8 @@ static const char *NONCE_SLOP = "SLOP";
static const char *nonce_status;
static long nonce_stamp_slop;
static unsigned long nonce_stamp_slop_limit;
-struct strbuf err = STRBUF_INIT;
-struct transaction *transaction;
+static struct strbuf err = STRBUF_INIT;
+static struct transaction *transaction;
static enum deny_action parse_deny_action(const char *var, const char *value)
{
atomic-push is negotiated", 21-10-2014) added the 'transaction'
and 'err' variables as external symbols.
Noticed by sparse. ("'err' was not declared. Should it be static?")
Signed-off-by: Ramsay Jones <***@ramsay1.demon.co.uk>
---
Hi Ronnie,
If you need to re-roll your 'rs/ref-transaction-send-pack' branch, could
you please squash this into the re-rolled version of commit 8796e182.
Thanks!
ATB,
Ramsay Jones
builtin/receive-pack.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/builtin/receive-pack.c b/builtin/receive-pack.c
index 030698c..7f6d814 100644
--- a/builtin/receive-pack.c
+++ b/builtin/receive-pack.c
@@ -68,8 +68,8 @@ static const char *NONCE_SLOP = "SLOP";
static const char *nonce_status;
static long nonce_stamp_slop;
static unsigned long nonce_stamp_slop_limit;
-struct strbuf err = STRBUF_INIT;
-struct transaction *transaction;
+static struct strbuf err = STRBUF_INIT;
+static struct transaction *transaction;
static enum deny_action parse_deny_action(const char *var, const char *value)
{
--
2.1.0
2.1.0